Add unit test for ensembl.io.genomio.genome_metadata.dump module #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatBarba
approved these changes
Feb 29, 2024
|
@MatBarba asked for a re-review due to the addition of updated and unit test for |
JAlvarezJarreta
changed the title
MatBarba
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all methods (review docstrings, improve readability and reduce code complexity) and added unit tests for all of them.
In the case of
get_genome_metadata()the rework whilst may not be as efficient as the previous code, I believe it is more readable and allows for further meta table checks in case the data found there does not match the expected format, e.g. isspeciesmeta key always has a subkey but there is an entry without, aValueErroris raised.Added to
__all__one of the functions that was missing.